Skip to content

Expanded allowed characters for owner name and repo name in a project URL and a resource URL. #25

Merged
EndBug merged 3 commits into
EndBug:mainfrom
teqbench:main
Oct 15, 2023
Merged

Expanded allowed characters for owner name and repo name in a project URL and a resource URL. #25
EndBug merged 3 commits into
EndBug:mainfrom
teqbench:main

Conversation

@ben-v
Copy link
Copy Markdown
Contributor

@ben-v ben-v commented Oct 11, 2023

Added . and _ to the allowed characters for owner name and repo name in a project URL and a resource URL.

…repo name in a project URL and a resource URL.
Copy link
Copy Markdown
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
While we're at it, why don't we also change it as I put in the suggestions? That would include also _ characters

Comment thread src/io.ts Outdated
Comment thread src/io.ts Outdated
@EndBug EndBug added the type: fix Updates to existing functionalities label Oct 15, 2023
@ben-v
Copy link
Copy Markdown
Contributor Author

ben-v commented Oct 15, 2023

I think I initially messed up w/ how I incorporated your changes, but I've made two commits to get the regex as you suggested, i.e. '\d\w-._'. Please see the two additional commits.

@EndBug
Copy link
Copy Markdown
Owner

EndBug commented Oct 15, 2023

@ben-v No problem, that works too 😄

Fyi, if you need more info on how to incorporate suggested PR changes, here's a quick link to GitHub docs ;)
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

Thanks for the PR, I'll merge it right away ❤️

@EndBug EndBug merged commit 965e112 into EndBug:main Oct 15, 2023
@ben-v
Copy link
Copy Markdown
Contributor Author

ben-v commented Oct 15, 2023

@ben-v No problem, that works too 😄

Fyi, if you need more info on how to incorporate suggested PR changes, here's a quick link to GitHub docs ;) https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

Thanks for the PR, I'll merge it right away ❤️

Ha..yes I def need to review those docs. Thanks for sending over!!

ben-v added a commit to teqbench-archive/teqbench.devops.forks.githhub.actions.project-fields that referenced this pull request Dec 6, 2023
* 'main' of https://github.com/teqbench/project-fields:
  chore(deps): bump @types/node from 20.8.3 to 20.8.10 (EndBug#31)
  chore(deps): bump @actions/github from 5.1.1 to 6.0.0 (EndBug#32)
  chore(deps): bump csv from 6.3.4 to 6.3.5 (EndBug#30)
  chore(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.0.1 (EndBug#29)
  chore(deps): bump @vercel/ncc from 0.38.0 to 0.38.1 (EndBug#28)
  ci(deps): bump actions/setup-node from 3 to 4 (EndBug#27)
  chore(deps): bump undici from 5.25.4 to 5.26.3 (EndBug#26)
  2.0.1
  Expanded allowed characters for owner name and repo name in a project URL and a resource URL.  (EndBug#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Updates to existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants