Merged
Conversation
added 2 commits
August 8, 2025 11:07
…require description of the super-field (and set the resource in parantheses)
JulStraus
approved these changes
Aug 11, 2025
Member
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Seems workable although it is not tested. My comment is essentially just for considering smoother approaches. It does not change the picture at all.
| # Search through EMX packages if icons are available there | ||
| for package ∈ emx_packages | ||
| package_path::Union{String,Nothing} = Base.find_package(package) | ||
| package_path::Union{String,Nothing} = dirname(dirname(Base.find_package(package))) |
Member
There was a problem hiding this comment.
The dirname(dirname()) approach seems a bit heavy, although it is pretty much the same as before. I know that pkgdir is directly providing the root folder, but it is only working on the module which we do not get here.
Note that this is just a comment.
Collaborator
Author
There was a problem hiding this comment.
Yes, there was occations where the previous approach did not work. One could have used the abspath-function, but I thought this was better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the descriptive names for nodes having dictionaries with keys of type
Resourceas in the MultipleBuildingTypes-node in the EnergyModelsLanguageInterfaces.jl. Testing this functionality should be added once the package is registered.Also cleaned up some code.