Skip to content

Fix bug in nodes_in_area-function#45

Merged
JulStraus merged 1 commit intoEnergyModelsX:mainfrom
Zetison:fix/type_error_in_nodes_in_area
Nov 25, 2025
Merged

Fix bug in nodes_in_area-function#45
JulStraus merged 1 commit intoEnergyModelsX:mainfrom
Zetison:fix/type_error_in_nodes_in_area

Conversation

@Zetison
Copy link
Copy Markdown

@Zetison Zetison commented Nov 24, 2025

Use Link instead of Direct to facilitate non-Direct Links in the nodes_in_area-function.

Copy link
Copy Markdown
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you spotted it. Do you think it is worth to update the NEWS.md with it or leave it aside?

@Zetison
Copy link
Copy Markdown
Author

Zetison commented Nov 25, 2025

Good that you spotted it. Do you think it is worth to update the NEWS.md with it or leave it aside?

I think it is fine without, as I assume the usage of this function is rare and the previous state would return errors anyways.

@JulStraus JulStraus merged commit 3c418c8 into EnergyModelsX:main Nov 25, 2025
5 checks passed
@Zetison Zetison deleted the fix/type_error_in_nodes_in_area branch November 25, 2025 09:03
Zetison pushed a commit to EnergyModelsX/EnergyModelsGUI.jl that referenced this pull request Dec 16, 2025
Zetison pushed a commit to EnergyModelsX/EnergyModelsGUI.jl that referenced this pull request Dec 16, 2025
* Use EMG v0.11.3 to resolve a bug resolved in its PR http://EnergyModelsX/EnergyModelsGeography.jl#45

* Enabled exporting topo axis to bmp, tif, tiff, jpg, jpeg, and png file format.

* Adjusted `descriptive_names` to be more robust to available packages. Introduced module names as intermediate `Dict`s in the `structures` field of `descriptive_names` (this is a breaking change).

* Enable custom boundary background map instead of the default coastlines (through a `.geojson` file location provided by the keyword argument `map_boundary_file` in the `GUI`-function).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants