Skip to content

🐛 Update settings to overwrite graphs#1001

Merged
tsmbland merged 1 commit into93_graph_validationfrom
982_overwrite_graph
Nov 12, 2025
Merged

🐛 Update settings to overwrite graphs#1001
tsmbland merged 1 commit into93_graph_validationfrom
982_overwrite_graph

Conversation

@dalonsoa
Copy link
Copy Markdown
Collaborator

Description

Minor fix to enable this, following how it is done in other CLI options.

Fixes #982

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.85%. Comparing base (bde422a) to head (b93cff2).
⚠️ Report is 2 commits behind head on 93_graph_validation.

Files with missing lines Patch % Lines
src/cli.rs 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           93_graph_validation    #1001      +/-   ##
=======================================================
- Coverage                83.90%   83.85%   -0.05%     
=======================================================
  Files                       52       52              
  Lines                     5833     5836       +3     
  Branches                  5833     5836       +3     
=======================================================
  Hits                      4894     4894              
- Misses                     704      705       +1     
- Partials                   235      237       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dalonsoa dalonsoa changed the title 🐛 Update settings ton override graphs 🐛 Update settings to override graphs Nov 12, 2025
@dalonsoa dalonsoa changed the title 🐛 Update settings to override graphs 🐛 Update settings to overwrite graphs Nov 12, 2025
@dalonsoa dalonsoa requested review from Aurashk and tsmbland November 12, 2025 10:09
@dalonsoa dalonsoa linked an issue Nov 12, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tsmbland tsmbland merged commit 9a623f3 into 93_graph_validation Nov 12, 2025
7 of 8 checks passed
@tsmbland tsmbland deleted the 982_overwrite_graph branch November 12, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--overwrite option not working for save-graphs command

2 participants