Skip to content

Enable year ranges in input files#1017

Merged
tsmbland merged 12 commits intomainfrom
845_range_inputs
Nov 25, 2025
Merged

Enable year ranges in input files#1017
tsmbland merged 12 commits intomainfrom
845_range_inputs

Conversation

@dalonsoa
Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa commented Nov 24, 2025

Description

Enable defining multiple consecutive years as a range in the input file as start..end. If provided, the limits of the range are both inclusive. If either is missing, they are made equal to the start or end of the valid range provided, respectively.

Todo

  • Adapt existing input files to use time range, where relevant -> there are none
  • Update documentation to explain this option -> schemas updated

Fixes #845

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.07%. Comparing base (58d11c3) to head (d118339).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/year.rs 97.36% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   80.99%   81.07%   +0.08%     
==========================================
  Files          52       52              
  Lines        6299     6331      +32     
  Branches     6299     6331      +32     
==========================================
+ Hits         5102     5133      +31     
  Misses        942      942              
- Partials      255      256       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dalonsoa dalonsoa marked this pull request as draft November 24, 2025 14:06
@dalonsoa dalonsoa marked this pull request as ready for review November 24, 2025 17:25
@dalonsoa dalonsoa requested review from Aurashk and tsmbland November 24, 2025 17:25
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a small change to disallow having multiple ".."s in a range (e.g. "..2020..2030"), but otherwise all good!

@tsmbland tsmbland enabled auto-merge November 25, 2025 11:20
@tsmbland tsmbland merged commit 19f72c2 into main Nov 25, 2025
8 checks passed
@tsmbland tsmbland deleted the 845_range_inputs branch November 25, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow year ranges in input files

2 participants