-
Notifications
You must be signed in to change notification settings - Fork 2
Compute demand map when loading in data #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5fbcff8
Fix: Don't reuse mutable demand object between tests
alexdewar 754af64
Rename: `DemandHashMap` => `CommodityDemandMap`
alexdewar c0f5935
Make bespoke `DemandMap` type with `get` method
alexdewar f90f1a7
Require demand entry year to be milestone year
alexdewar 181d3d1
Check demand quantity is valid
alexdewar e260ac2
Move check that fractions sum to one to input.rs
alexdewar 422ec1d
Compute demand for each time slice when loading data
alexdewar b15b63a
Remove unnecessarily verbose error-checking
alexdewar 49c180a
Require demand entries for all milestone years
alexdewar f9cc83c
Check for demand slicing provided without corresponding entry in dema…
alexdewar b88758b
Merge branch 'main' into demand-time-slice-map
alexdewar b91fc83
Remove outdated comment
alexdewar 04522d5
Move demand CSV code into submodule of `input`
alexdewar 48ba07c
Rename: mod test to mod tests
alexdewar 10aa75c
Move demand slicing code into own submodule
alexdewar bcf643f
Rename: DEMAND_SLICES_FILE_NAME => DEMAND_SLICING_FILE_NAME
alexdewar 1fa3f1e
Remove redundant check
alexdewar 941292c
Add a longer doc comment for `compute_demand_map`
alexdewar de1b4a6
Rename: `compute_demand_map` => `compute_demand_maps`
alexdewar 1cbee62
TimeSliceInfo: iter{_selection}: Return fraction along with TimeSliceID
alexdewar 69aa5d6
Put calculation of time slice share into separate function
alexdewar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| commodity_id,region_id,year,demand | ||
| RSHEAT,GBR,2020,927.38 | ||
| RSHEAT,GBR,2100,927.38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DemandMapis what's called a newtype. Essentially it's a struct with an unnamedHashMapinside it, andself.0is how you access it.