Move CSV-related process code to input module#296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 95.15% 95.25% +0.10%
==========================================
Files 19 25 +6
Lines 2619 2615 -4
Branches 2619 2615 -4
==========================================
- Hits 2492 2491 -1
+ Misses 50 48 -2
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
TinyMarsh
left a comment
There was a problem hiding this comment.
Cool! Admittedly I haven't scrutinised every line change here so this is a passing review but it looks good to me, and I have built and tested and had no problems running.
|
Great! Thanks for testing 😄 |
|
I'm going to merge this even though it only has one review as the changes are non-functional and are broadly in line with what was agreed in the meeting, so that I can start working on some other things on top of this. We can always tweak things later. |
Description
This PR continues the refactoring work to move all CSV-related code into submodules of
inputby doing this forprocess.rs. The code has been further split into various submodules ofinput::processfor clarity.The last commit (147729c) is the only one that actually changes anything (though it should still be a non-functional change). Everything else is just to do with moving code.
Closes #286.
Type of change
Key checklist
$ cargo test$ cargo docFurther checks