Move time slice CSV code to input submodule#345
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 95.71% 95.68% -0.03%
==========================================
Files 27 28 +1
Lines 3223 3224 +1
Branches 3223 3224 +1
==========================================
Hits 3085 3085
- Misses 61 62 +1
Partials 77 77 ☔ View full report in Codecov by Sentry. |
dalonsoa
approved these changes
Jan 21, 2025
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
This looks ok. Just to confirm, there's no functional change, just moving things around, right?
Collaborator
Author
Yep, exactly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the time slice CSV code to a submodule of
input, as we've done for all the other modules now. This is the last bit of refactoring related to #281.No functional changes.
Closes #288. Closes #281.
Type of change
Key checklist
$ cargo test$ cargo docFurther checks