Skip to content

Comments

Move time slice CSV code to input submodule#345

Merged
alexdewar merged 1 commit intomainfrom
move-csv-code-time-slice
Jan 22, 2025
Merged

Move time slice CSV code to input submodule#345
alexdewar merged 1 commit intomainfrom
move-csv-code-time-slice

Conversation

@alexdewar
Copy link
Collaborator

@alexdewar alexdewar commented Jan 21, 2025

Description

This PR moves the time slice CSV code to a submodule of input, as we've done for all the other modules now. This is the last bit of refactoring related to #281.

No functional changes.

Closes #288. Closes #281.

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.68%. Comparing base (b8d9fe8) to head (5c99247).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/input/time_slice.rs 95.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   95.71%   95.68%   -0.03%     
==========================================
  Files          27       28       +1     
  Lines        3223     3224       +1     
  Branches     3223     3224       +1     
==========================================
  Hits         3085     3085              
- Misses         61       62       +1     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. Just to confirm, there's no functional change, just moving things around, right?

@alexdewar
Copy link
Collaborator Author

This looks ok. Just to confirm, there's no functional change, just moving things around, right?

Yep, exactly

@alexdewar alexdewar merged commit 0a600a9 into main Jan 22, 2025
7 checks passed
@alexdewar alexdewar deleted the move-csv-code-time-slice branch January 22, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time_slice.rs: Move CSV-related code to input/ Move CSV-related code into submodules of input

2 participants