Add validation to SED type commodities

[TinyMarsh]

Description

This pull request focuses on validation of commodities. The most important change includes the implementation of a commodity validation function, and the creation of a corresponding test.

Fixes #167

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Attention: Patch coverage is 98.34711% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (6637473) to head (20af3b0).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/input/process.rs	98.34%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   96.03%   96.11%   +0.08%     
==========================================
  Files          27       27              
  Lines        3279     3400     +121     
  Branches     3279     3400     +121     
==========================================
+ Hits         3149     3268     +119     
  Misses         60       60              
- Partials       70       72       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexdewar]

Looks good! I've made some minor suggestions.

I would split the actual check into its own separate function to make things a bit more modular and so that you can return early once you've found a producer and consumer.

[TinyMarsh]

Thanks @alexdewar. I've pulled out the checks specific to SED commodities into their own function and implemented your other suggestions.

[alexdewar]

Hey,

Sorry I forgot to re-review this! Looks good. I've made one small suggestion (you can return early from validate_sed_commodity), but other than that, I think we're good to merge.

[TinyMarsh]

Cool. I would have needed to wrap the anyhow! in an Err and return that like:

    return Err(anyhow!(
        "Commodity {} of 'SED' type must have both producer and consumer processes",
        commodity_id
    ));

But it looks like bail! is a shorthand macro for that so I used that instead :) https://docs.rs/anyhow/latest/anyhow/