Fix build on gcc v15 by updating highs-sys dependency#608
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 84.76% 84.79% +0.03%
==========================================
Files 37 37
Lines 3301 3301
Branches 3301 3301
==========================================
+ Hits 2798 2799 +1
+ Misses 314 313 -1
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmbland
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current version of
highs-sysspecified inCargo.lockdoesn't compile on gcc v15, but a new version with a fix has been released. As it's an indirect dependency (unlike the mainhighscrate), it won't be updated by dependabot, so we need to update it manually. I've done this by runningcargo update.Fixes #517.
Type of change
Key checklist
$ cargo test$ cargo docFurther checks