Fix: Remove use of removed settings dump-default from release workflow#873
Merged
Fix: Remove use of removed settings dump-default from release workflow#873
settings dump-default from release workflow#873Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 85.18% 85.18%
=======================================
Files 50 50
Lines 5300 5300
Branches 5300 5300
=======================================
Hits 4515 4515
Misses 565 565
Partials 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmbland
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I accidentally broke the release workflow in #860 (I noticed because we run it on pushes to
main). I'd changed it to generate the bundledsettings.tomlfile using thesettings dump-defaultcommand and forgot to update it after I changed the command's name.On reflection, though, I don't think we actually need that file anymore anyway: users can get information about the possible settings by just running
muse2 settings edit. So I've just removed it.Type of change
Key checklist
$ cargo test$ cargo docFurther checks