Skip to content

add trimming to csv reader in main csv reader function#976

Merged
Aurashk merged 1 commit intomainfrom
add-trimming-for-input-csv
Oct 30, 2025
Merged

add trimming to csv reader in main csv reader function#976
Aurashk merged 1 commit intomainfrom
add-trimming-for-input-csv

Conversation

@Aurashk
Copy link
Copy Markdown
Collaborator

@Aurashk Aurashk commented Oct 29, 2025

Description

Makes the csv reader able to handle files where the entries have leading/trailing whitespace

Fixes #648

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

add test for csv files with whitespace
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (a66a0f7) to head (48e525c).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   84.09%   84.13%   +0.04%     
==========================================
  Files          50       50              
  Lines        5683     5699      +16     
  Branches     5683     5699      +16     
==========================================
+ Hits         4779     4795      +16     
  Misses        671      671              
  Partials      233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aurashk Aurashk requested a review from tsmbland October 29, 2025 14:18
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Aurashk Aurashk merged commit 6953c2d into main Oct 30, 2025
8 checks passed
@Aurashk Aurashk deleted the add-trimming-for-input-csv branch October 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trim whitespace from headers and fields in CSV files

2 participants