Invalid values for minimum service factor in test_minimum_service_factor #320
Description
As established in #304, MinimumServiceFactor should be between 0 and 1. However, the test_minimum_service_factor test uses invalid values >1, and still passes
Ideally we shouldn't be in a position where the model can be run with invalid values, however at the very least this test should be modified to use valid values.
It's also worth making sure this test is checking the correct thing. It seems to be comparing the absolute value of supply against the MinimumServiceFactor, however my understanding is that MinimumServiceFactor relates to relative supply compared to the theoretical maximum (hence why it needs to be between 0 and 1). Or maybe I'm misunderstanding something...