-
Notifications
You must be signed in to change notification settings - Fork 10
Add updated installation instructions #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8e6c6d7
Add uptodate installation instructions
dalonsoa dd72863
Remove unused dependency
dalonsoa 65aab2e
Fix wrong formating of links
dalonsoa bbad461
Clarify summary note
dalonsoa 1dba66a
Add output simulation
dalonsoa 8cdb957
Clarify the use of venv
dalonsoa b7b8c73
Be agnostic on the environment to use when installing MUSE from source
dalonsoa 69b9328
Merge branch 'develop' into new_installation
sgiarols c24f555
Merge branch 'develop' into new_installation
dalonsoa 840a085
Merge branch 'new_installation' of https://github.com/SGIModel/MUSE_O…
dalonsoa e1f719d
Update changelog
dalonsoa cf73c23
Generalize the number of python alias to disable in Windows
dalonsoa 9db6aee
Fix typo and make some rewording to clarify instructions
dalonsoa 326c273
Add note on using ``py`` in Windows
dalonsoa dc8c931
Merge branch 'develop' into new_installation
dalonsoa 8f4dec6
Update output example of running simulation
dalonsoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -167,3 +167,5 @@ shell.nix | |
| model/ | ||
|
|
||
| *.html | ||
|
|
||
| .idea/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to have the instructions only on one side to avoid repetitions. We would need a direct link to the documentation from the README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the text of the PR it is indicated that the README needs updating once this is merge. I cannot update the README until that happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, OK, so I misunderstood and the README would still have back again the info on the installation once the doc is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think I was not clear either. The README will be short, as I have left it, but the link to the documentation in RdDs cannot be added until this is merged because there's nothing to point to (I can point to the documentation overall, but not to the specific sections of it because those have changed). Is it clearer?