Revert "Enforce minimum service factor limits"#327
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #327 +/- ##
===========================================
+ Coverage 71.09% 71.11% +0.01%
===========================================
Files 44 44
Lines 5812 5809 -3
Branches 1148 1147 -1
===========================================
- Hits 4132 4131 -1
+ Misses 1359 1358 -1
+ Partials 321 320 -1 ☔ View full report in Codecov by Sentry. |
dalonsoa
approved these changes
Jun 5, 2024
Collaborator
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
I'm not entirely sure what's going on, but looks ok.
Collaborator
Author
|
So I made the changes you suggested on the last PR, pushed them and clicked auto-merge, then it merged before actually running the tests, many of which actually failed 🙃 |
Collaborator
Author
|
I'll open a new PR once I've fixed the test failures. I just didn't want to leave the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #325
It seems that the tests are now failing on
developand I didn't catch this before merging (see #306). Sorry!