Skip to content

Comments

Changes default solver to scipy#378

Closed
dalonsoa wants to merge 2 commits intodevelopfrom
dalonsoa-patch-1
Closed

Changes default solver to scipy#378
dalonsoa wants to merge 2 commits intodevelopfrom
dalonsoa-patch-1

Conversation

@dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Jun 27, 2024

Description

Sets the default solver to scipy, updating also the settings files.

Fixes # N/A

Type of change

Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (a2a1b4f) to head (371f5d1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #378      +/-   ##
===========================================
- Coverage    71.39%   71.13%   -0.26%     
===========================================
  Files           44       44              
  Lines         5887     5887              
  Branches      1162     1162              
===========================================
- Hits          4203     4188      -15     
- Misses        1364     1383      +19     
+ Partials       320      316       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalonsoa dalonsoa requested review from alexdewar and tsmbland June 27, 2024 09:57
@dalonsoa dalonsoa marked this pull request as ready for review June 27, 2024 09:57
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsmbland
Copy link
Collaborator

tsmbland commented Jul 2, 2024

Shall we merge this?

@ahawkes
Copy link
Collaborator

ahawkes commented Jul 3, 2024

I think we hold off on this for now. I think it will be a breaking (or at least disconcerting) change for some models (that use adhoc by default)

@dalonsoa
Copy link
Collaborator Author

dalonsoa commented Jul 4, 2024

I'm going to close this. We will revisit in the future if/when needed.

@dalonsoa dalonsoa closed this Jul 4, 2024
@dalonsoa dalonsoa deleted the dalonsoa-patch-1 branch July 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📁 Archive

Development

Successfully merging this pull request may close these issues.

4 participants