Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #378 +/- ##
===========================================
- Coverage 71.39% 71.13% -0.26%
===========================================
Files 44 44
Lines 5887 5887
Branches 1162 1162
===========================================
- Hits 4203 4188 -15
- Misses 1364 1383 +19
+ Partials 320 316 -4 ☔ View full report in Codecov by Sentry. |
tsmbland
approved these changes
Jun 27, 2024
Collaborator
|
Shall we merge this? |
Collaborator
|
I think we hold off on this for now. I think it will be a breaking (or at least disconcerting) change for some models (that use adhoc by default) |
Collaborator
Author
|
I'm going to close this. We will revisit in the future if/when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets the default solver to scipy, updating also the settings files.
Fixes # N/A
Type of change
Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks