Increase maximum_iterations parameter to 100#386
Merged
tsmbland merged 3 commits intodocumentationfrom Jul 2, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## documentation #386 +/- ##
=================================================
- Coverage 71.36% 71.25% -0.11%
=================================================
Files 44 44
Lines 5901 5901
Branches 1166 1166
=================================================
- Hits 4211 4205 -6
- Misses 1370 1374 +4
- Partials 320 322 +2 ☔ View full report in Codecov by Sentry. |
dalonsoa
approved these changes
Jul 2, 2024
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
Looks sensible to me. It's interesting to see how the output files change, adding more assets installed in the future years. I hope those changes still make sense!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The example models were previously using a range of values for the
maximum_iterationsparameter, ranging from 1 to 100. As explained in the issue (#372), this should be a high number, so I've changed all the models to use 100 and regenerated the results files.I've also changed the default value from 3 to 100 (i.e. when not specified in the settings file)
I've based this PR off #349 as that one is already changing all the results files. There may be some text changes required in the notebooks (e.g. describing plots), but I'll address these sorts of things in #349 once this is merged
Fixes #372
Type of change
Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks