Correctly use the minimum service factor#388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## even-better-toml #388 +/- ##
====================================================
+ Coverage 71.34% 71.37% +0.03%
====================================================
Files 44 44
Lines 5890 5890
Branches 1162 1162
====================================================
+ Hits 4202 4204 +2
+ Misses 1366 1365 -1
+ Partials 322 321 -1 ☔ View full report in Codecov by Sentry. |
alexdewar
left a comment
alexdewar
left a comment
There was a problem hiding this comment.
LGTM, other than the one question I have.
| ) | ||
| capacity = convert_timeslice( | ||
| techs.fixed_outputs * techs.utilization_factor * techs.minimum_service_factor, | ||
| techs.fixed_outputs * techs.minimum_service_factor, |
There was a problem hiding this comment.
Where does the division by the maximum output happen?
There was a problem hiding this comment.
It doesn't: the minimum service factor is the result of that division, that is why it is a fraction! fixed_outputs would be the absolute maximum and you multiply it by utilization_factor or the minimum_service_factor to recover the upper and lower limits of the production.
|
Did you mean to merge this into the |
|
No, my mistake :( |
3 participants
Description
As ti was being used as a fraction of the utilisation factor rather as a fraction of 100%.
Fixes #375
Type of change
Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks