Change column titles and order#398
Merged
tsmbland merged 2 commits intonew-data-inputfrom Jul 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-data-input #398 +/- ##
==================================================
+ Coverage 71.33% 71.37% +0.03%
==================================================
Files 44 44
Lines 5921 5921
Branches 1169 1169
==================================================
+ Hits 4224 4226 +2
+ Misses 1374 1373 -1
+ Partials 323 322 -1 ☔ View full report in Codecov by Sentry. |
alexdewar
approved these changes
Jul 3, 2024
Collaborator
alexdewar
left a comment
There was a problem hiding this comment.
There are a few columns which I think should be just id. I'd request changes but I'm going away and don't want to block merging.
Collaborator
There was a problem hiding this comment.
I think I may have missed something, but what are agent pairs about?
Collaborator
Author
There was a problem hiding this comment.
This is because agents have typically been made up of new and retrofit shares, so this is a way to link them together. I might change this later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In line with the discussion here, I'm changing some of the column titles to be clearer. I've also made the column order more consistent between tables.