Fix error message in scipy_match_demand#401
Conversation
|
Or not... |
|
I'm not sure I understand. Except for the |
|
It's this error message, which is raised when the solver can't find a solution (which is supposed to give a nice message but now just complains that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #401 +/- ##
===========================================
- Coverage 71.36% 71.36% -0.01%
===========================================
Files 44 44
Lines 5916 5915 -1
Branches 1162 1162
===========================================
- Hits 4222 4221 -1
Misses 1371 1371
Partials 323 323 ☔ View full report in Codecov by Sentry. |
|
Ok now it looks better |
dalonsoa
left a comment
There was a problem hiding this comment.
Assuming the failing windows check isn't relevant, it looks good!
|
|
||
| from muse.constraints import ScipyAdapter | ||
|
|
||
| df_technologies = technologies.to_dataframe() |
There was a problem hiding this comment.
So... is this not needed anymore?
There was a problem hiding this comment.
Nope. Previously it was converting the xarray to a dataframe and then getting the list of technologies from the dataframe, but you can get this directly from the xarray (and the dataframe isn't used anywhere else)
I just realised that one of the changes I made in #381 broke an error message in the
scipy_match_demandfunction. This fixes it