334 change minimum service factor for default timeslices model#403
Merged
HarmonicReflux merged 2 commits intodevelopfrom Jul 9, 2024
Merged
Conversation
…aTimeslices.csv for residential sector. Also, reworked relevant part of the notebook documentation.
…actor set to zero.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #403 +/- ##
===========================================
- Coverage 71.39% 71.36% -0.04%
===========================================
Files 44 44
Lines 5915 5915
Branches 1162 1162
===========================================
- Hits 4223 4221 -2
- Misses 1370 1371 +1
- Partials 322 323 +1 ☔ View full report in Codecov by Sentry. |
tsmbland
approved these changes
Jul 8, 2024
| "| windturbine | R1 | 2020 | all-year | all-week | afternoon | 1 | 0 |\n", | ||
| "| windturbine | R1 | 2020 | all-year | all-week | early-peak | 1 | 0 |\n", | ||
| "| windturbine | R1 | 2020 | all-year | all-week | late-peak | 1 | 0 |\n", | ||
| "| windturbine | R1 | 2020 | all-year | all-week | evening | 1 | 0 |\n" |
Collaborator
There was a problem hiding this comment.
This looks a lot uglier on github than it did in pycharm, but it's probably still fine
Collaborator
There was a problem hiding this comment.
Actually it depends on the screen width
HarmonicReflux
deleted the
334_change_MinimumServiceFactor_for_default_timeslices_model
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I set the MinimumServiceFactor for the power sector in TechnodataTimeslices.csv to zero and deleted the corresponding unused file in the residential sector. Moreover, I reworked the documentation in the explanatory tutorial notebook and re-run the models using generate_models.py and run_models.py such that the changes are picked up by the results files.
Fixes #334
Type of change
Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks