Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #420 +/- ##
===========================================
- Coverage 71.38% 71.35% -0.04%
===========================================
Files 44 44
Lines 5893 5893
Branches 1160 1156 -4
===========================================
- Hits 4207 4205 -2
- Misses 1366 1367 +1
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. |
dalonsoa
left a comment
There was a problem hiding this comment.
Looks good. The code is way more readable now, in addition to fixing the bugs, which is always good news.
| data_agent = multiindex_to_coords(data_agent, "timeslice").to_dataframe( | ||
| "fuel_consumption_costs" | ||
| ) | ||
| if not data_agent.empty: | ||
| data_sector.append(data_agent) |
There was a problem hiding this comment.
This looks ok, but it is doing something different than before. I assume this is correct, but I'm not sure why it is.
There was a problem hiding this comment.
ah, ok, you are combining it with what it was being done afterwards. OK, looks fine.
|
FYI @tsmbland I'm just going through your PRs now |
alexdewar
left a comment
There was a problem hiding this comment.
I've only given it a quick scan, but LGTM!
Description
Fixes a couple of issues with the costs outputs in
outputs/mca.py. The first of which emerged after we upgraded pandas/xarray, the second was an issue before (but was never caught).Changes:
multiindex_to_coordsto fix theValueError: cannot insert hour, already existserrorRemaining problems with the costs outputs:
Fixes #383
Type of change
Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks