Skip to content

Comments

Adapt codebase for compatibility with NumPy >= 2.0#425

Merged
HarmonicReflux merged 4 commits intodevelopfrom
numpy2
Jul 24, 2024
Merged

Adapt codebase for compatibility with NumPy >= 2.0#425
HarmonicReflux merged 4 commits intodevelopfrom
numpy2

Conversation

@tsmbland
Copy link
Collaborator

@tsmbland tsmbland commented Jul 22, 2024

Description

This pull request updates the codebase to ensure compatibility with NumPy version 2.0 and above. Changes include:

  • Adjustments to specific functions and modules to accommodate new features and changes in NumPy 2.0.
  • Updates to tests to ensure they pass with the new NumPy version.

Fixes #425

Type of change

Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • [ x] All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

  • [x ] Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland tsmbland linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@HarmonicReflux HarmonicReflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"grouped_by\n" is superfluous and has no effect in the cell.

@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.35%. Comparing base (93d225f) to head (aeb0fbe).

Files Patch % Lines
src/muse/mca.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #425      +/-   ##
===========================================
- Coverage    71.35%   71.35%   -0.01%     
===========================================
  Files           44       44              
  Lines         5879     5878       -1     
  Branches      1152     1152              
===========================================
- Hits          4195     4194       -1     
  Misses        1364     1364              
  Partials       320      320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarmonicReflux HarmonicReflux marked this pull request as ready for review July 24, 2024 02:31
@HarmonicReflux HarmonicReflux changed the title Make it work with Numpy2 Adapt codebase for compatibility with NumPy >= 2.0 Jul 24, 2024
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarmonicReflux HarmonicReflux merged commit d644f9c into develop Jul 24, 2024
@HarmonicReflux HarmonicReflux deleted the numpy2 branch July 24, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incompatible with Numpy 2.0 [BUG]

3 participants