Update documentation for demand_share parameter#433
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #433 +/- ##
===========================================
- Coverage 71.35% 71.31% -0.04%
===========================================
Files 44 44
Lines 5878 5878
Branches 1152 1152
===========================================
- Hits 4194 4192 -2
- Misses 1364 1365 +1
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The options have changed since the documentation was last updated, as well as the default value.
Also, whilst #349 changed the default value to "standard_demand" in the sense that if
demand_shareisn't specified in the settings file it will default to this value, if you wrotedemand_share = "default"it would still default to "new_and_retro". So I've fixed that.Close #341