Fix inconsistent reading of agent share names

[tsmbland]

Description

Agent shares are specified in the agents files, and then referenced in technodata files to assign a share of existing capacity to the agent. The names specified in the technodata files must match the agents file, otherwise an error will be raised. However, as @Jin-Jun-Mei found, in some cases even when the names do match an error can still be raised.

The reason is that the process for reading in the agent share names is different for the agents file and technodata files. For the agents file (read_csv_agent_parameters), names are converted using a sub operation. For technodata files (read_technodictionary), names are first converted to snake case and then converted using a similar sub operation. If following conventional naming schemes, these end up being equivalent, but if you deviate from this you can end up with inconsistencies and MUSE complaining that you haven't specified an agent share which you have.

I've simplified this so that in both cases were just converting to snake case. This should leave no room for inconsistency, as long as the names match in the files. I've updated the documentation to make it clear that names should match between the files.

Also the trade model needed updating as the names didn't match between the files

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass: $ python -m pytest
• The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[dalonsoa]

Nice and simple.