Fix conditions for completion of demo game #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The demo game states that you should deliver the RFC to the developers. Added condition that you have to be in the same room as bill the developer.
You could remove the whole space change-block directly from GH, it is quicker than via the GUI. |
Trailing spaces added back to statements which weren't changed to reduce the "foot print" of the pull request.
![abaplint[bot]](https://avatars.githubusercontent.com/in/960?s=60&v=4){kind=small}
| result->add( |You are in the { engine->player->location->name }.| ). " { player->location->description }|. | ||
| text->set_textstream( result->get( ) ). | ||
|
|
||
| IF engine->player->location->things->exists( 'RFC' ). |
There was a problem hiding this comment.
Remove whitespace at end of line
Suggest following fix,
Suggested change
| DATA(entrance) = NEW room( | |
| DATA(entrance) = NEW room( |
Contributor
Author
|
Trailing spaces inserted again, so now there's one more error message from abaplint :-) |
Owner
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo game states that you should deliver the RFC to the developers. Added condition that you have to be in the same room as Bill the developer.
Seems some space characters were removed too - that wasn't intentional.