Skip to content

Documenting the delta between EDB system catalogs and information available in PostgreSQL#5038

Merged
nidhibhammar merged 8 commits intodevelopfrom
docs/epas/system-catalog-discrepancies
Jan 9, 2024
Merged

Documenting the delta between EDB system catalogs and information available in PostgreSQL#5038
nidhibhammar merged 8 commits intodevelopfrom
docs/epas/system-catalog-discrepancies

Conversation

@dwicinas
Copy link
Contributor

@dwicinas dwicinas commented Nov 22, 2023

Added files for:

pg_attribute
pg_authid
pg_class
pg_collation
pg_database
pg_namespace
pg_partitioned_table
pg_proc
pg_subscription
pg_synonym
pg_trigger
pg_type
pg_user

Addresses https://enterprisedb.atlassian.net/browse/DF-368

@dwicinas dwicinas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Nov 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023

@github-actions github-actions bot temporarily deployed to pr-5038-docs-epas-system-catalog-discrepancies November 22, 2023 17:41 Inactive
@djw-m djw-m force-pushed the docs/epas/system-catalog-discrepancies branch from 8a1b535 to c704a6e Compare November 23, 2023 13:41
@github-actions github-actions bot temporarily deployed to pr-5038-docs-epas-system-catalog-discrepancies November 23, 2023 13:55 Inactive
…ence/epas_compat_cat_views/pg_views/pg_attribute.mdx

Co-authored-by: nidhibhammar <59045594+nidhibhammar@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pr-5038-docs-epas-system-catalog-discrepancies November 28, 2023 14:23 Inactive

| Name | Type | Description |
| --------------------- | ------- | ----------------------------------------------------------------------------------------------------- |
| relbackingtable | "char" | Specifies whether a table is backing relation for any other object. The default value is `d` for a normal object and `q` for queue tables. We store the relbackingtable as `q` for all the backing objects of QUEUE TABLE (backing table, index, toast table, and so forth). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using relbackingtable we can identify whether table is backing relation for

  • any other object. Default value for relbackingtable will be 'd' for normal
  • object and 'q' for queue tables. We store the relbackingtable as 'q' for all
  • the backing object of QUEUE TABLE (backing table, index, toast table, etc).
    */

@github-actions github-actions bot temporarily deployed to pr-5038-docs-epas-system-catalog-discrepancies November 29, 2023 15:00 Inactive
Copy link
Contributor

@tusharahuja tusharahuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided all the comments for the missing description and other than that - the rest looks good. Thanks.

| nspobjecttype | oid | |
| nspparent | oid | |
| nspremoteschema | text | |
| nspsecdef | boolean | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nspname - Name of the namespace
nspowner - Owner of the namespace
nspparent - Schema (Namespace) of the Package (0 for regular schema)
nspobjecttype - Object Type to which this Package belongs to
nspforeignserver - Foreign Server where foreign namespace is
nspsecdef - Namespace (Package) is a security definer
nspcompoundtrigger - Is this a Compound Trigger's package
nspremoteschema - Name of the foreign namespace
nspheadsrc - Header of a Package
nspbodysrc - Body of a Package

@github-actions github-actions bot temporarily deployed to pr-5038-docs-epas-system-catalog-discrepancies December 4, 2023 13:33 Inactive
@nidhibhammar
Copy link
Contributor

@tusharahuja, can you have a look if any further changes are needed.

@nidhibhammar
Copy link
Contributor

@tusharahuja, can you have look at it, and let us know if any further changes are required

Copy link
Contributor

@tusharahuja tusharahuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-05 at 12 22 54 PM

if we go to this page
https://deploy-preview-5038--edb-docs-staging.netlify.app/docs/epas/latest/reference/oracle_compatibility_reference/epas_compat_cat_views/pg_views/

We are saying
"
System catalog views v16
System catalog views are present in PostgreSQL. They may have extra information when accessed in EDB Postgres Advanced Server. The [PG_USER] view is an example of a system catalog view that provides additional information specific to EDB Postgres Advanced Server.
"
We need to remove this line

"The [PG_USER] view is an example of a system catalog view that provides additional information specific to EDB Postgres Advanced Server.
"
from there.

rest looks good.

@dwicinas
Copy link
Contributor Author

dwicinas commented Jan 8, 2024

@nidhibhammar I made the change suggested by Tushar. If you can mark it as reviewed, this one should be ready to merge.

Copy link
Contributor

@nidhibhammar nidhibhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nidhibhammar nidhibhammar merged commit 7b5fdbe into develop Jan 9, 2024
@nidhibhammar nidhibhammar deleted the docs/epas/system-catalog-discrepancies branch January 9, 2024 06:01
@josh-heyer josh-heyer mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy Add this label to a PR and it will automatically be deployed to netlify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants