Skip to content

Edits to PGD PR 5149#5174

Merged
djw-m merged 2 commits intodevelopfrom
docs/edits_to_pgd_pr5149
Jan 24, 2024
Merged

Edits to PGD PR 5149#5174
djw-m merged 2 commits intodevelopfrom
docs/edits_to_pgd_pr5149

Conversation

@ebgitelman
Copy link
Contributor

No description provided.

@ebgitelman ebgitelman requested a review from djw-m as a code owner January 23, 2024 15:43
@ebgitelman
Copy link
Contributor Author

@djw-m I understand you want emphasis on the word "all," but I don't recommend using all caps. In general, we don't use emphasis (instead using a note when something needs to stand out), but I'm okay with the italics here without the all caps.

@djw-m
Copy link
Contributor

djw-m commented Jan 23, 2024

The issue that this started with was that people were not getting the need for all nodes to respond. Not sure how a lower case italic all would look here to resolve the essential issue.

@ebgitelman
Copy link
Contributor Author

The issue that this started with was that people were not getting the need for all nodes to respond. Not sure how a lower case italic all would look here to resolve the essential issue.

Can you make it a note? Or qualify it like this:

A global DML lock is granted only when all the eligible data nodes agree to grant it.

Or

All eligible data notes must agree to grant a global DML lock before the lock is granted.

@djw-m
Copy link
Contributor

djw-m commented Jan 23, 2024

A note could easily be skipped. I'm fairly happy with

All eligible data notes must agree to grant a global DML lock before the lock is granted.

Using bold over italic.

As per our discussion
@ebgitelman
Copy link
Contributor Author

A note could easily be skipped. I'm fairly happy with

All eligible data notes must agree to grant a global DML lock before the lock is granted.

Using bold over italic.

Cool. This should be ready to be merged then. Thanks!

Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw-m djw-m merged commit 9db4e45 into develop Jan 24, 2024
@djw-m djw-m deleted the docs/edits_to_pgd_pr5149 branch January 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants