Merged
Conversation
Author
|
As I tested with NextCloud 14, object_type and object_id filters are not working. Haven't found it in issues on app github page, will test more and with earlier NextCloud versions, and will open an issue here if won't be able to make it work. UPD: fixed it, just needed to add |
|
You can rebase, I will do a proper review later. |
danil-topchiy
force-pushed
the
activities_api
branch
from
f300b3d to
a784449
Compare
Author
|
Rebased it |
|
The inspection completed: 2 new issues, 3 updated code elements |
Merged
|
LGTM, merging. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add class with activities api endpoint
Based on #11, will rebase to master after #11 will be merged
Nextcloud Activities api docs:
https://github.com/nextcloud/activity/blob/master/docs/endpoint-v2.md