Skip to content

feat: Added ItemAccordion component to ui#277

Merged
AleksandarDev merged 6 commits intomainfrom
feature/item-accordion
Jan 8, 2024
Merged

feat: Added ItemAccordion component to ui#277
AleksandarDev merged 6 commits intomainfrom
feature/item-accordion

Conversation

@jpaladin
Copy link
Copy Markdown
Contributor

@jpaladin jpaladin commented Jan 4, 2024

No description provided.

@AleksandarDev AleksandarDev requested review from a team, AleksandarDev and DorijanH and removed request for AleksandarDev and DorijanH January 6, 2024 09:14
Comment thread packages/react-ui/changes/Added ItemAccordion component Outdated
@DorijanH DorijanH self-requested a review January 8, 2024 07:50
<MuiAccordionSummary
expandIcon={<ExpandMore color="primary" />}
{...rest}
sx={{ height: 56, ...rest.sx }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about the case when sx is something that cannot be spread?

Comment thread packages/react-ui/ItemAccordion/ItemAccordionActions.tsx Outdated
@AleksandarDev AleksandarDev self-requested a review January 8, 2024 23:28
Copy link
Copy Markdown
Member

@AleksandarDev AleksandarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AleksandarDev AleksandarDev merged commit c10a36f into main Jan 8, 2024
@AleksandarDev AleksandarDev deleted the feature/item-accordion branch January 8, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants