Skip to content

fix(react-ui/dropdown-button): Properly disabling the DropdownButton #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AleksandarDev merged 1 commit into from
Feb 5, 2024
Merged

fix(react-ui/dropdown-button): Properly disabling the DropdownButton #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-ui/DropdownButton/DropdownButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type DropdownButtonProps = Omit<ButtonProps, 'onClick'> & {
* @public
*/
export function DropdownButton({
options, onClick, icon, ...rest
Comment thread
AleksandarDev marked this conversation as resolved.
options, onClick, icon, disabled, ...rest
}: DropdownButtonProps) {
const id = useId();
const [open, setOpen] = useState(false);
Expand Down Expand Up @@ -60,7 +60,7 @@ export function DropdownButton({
{...rest}
aria-describedby={id}
onClick={handleButtonClick}
disabled={!options?.length}
disabled={disabled || !options?.length}
>
{icon}
</IconButton>
Expand All @@ -69,7 +69,7 @@ export function DropdownButton({
{...rest}
aria-describedby={id}
onClick={handleButtonClick}
disabled={!options?.length}
disabled={disabled || !options?.length}
/>
)}
<Popover
Expand Down
Empty file added ...ges/Fixed [DropdownButton] Properly disabling the button if the disable prop is passed in
View file
Open in desktop
Empty file.