Skip to content

fix(skills): remove empty plugins on skill removal#410

Merged
christso merged 2 commits into
mainfrom
fix/remove-skill-cleanup
May 20, 2026
Merged

fix(skills): remove empty plugins on skill removal#410
christso merged 2 commits into
mainfrom
fix/remove-skill-cleanup

Conversation

@christso
Copy link
Copy Markdown
Contributor

Summary

  • remove the whole plugin entry when removing a skill would leave that plugin with zero enabled skills
  • keep multi-skill plugins installed and remove only the selected skill when other skills remain enabled
  • share the removal logic between the CLI command and TUI, and cover the edge cases with unit tests

E2E

Single-skill GitHub source

cd /tmp/allagents-remove-skill-red-9vBqlQ/demo
HOME=/tmp/allagents-remove-skill-red-9vBqlQ/home node /home/entity/projects/EntityProcess/allagents.worktrees/fix-remove-skill-cleanup/dist/index.js skill remove llm-wiki
HOME=/tmp/allagents-remove-skill-red-9vBqlQ/home node /home/entity/projects/EntityProcess/allagents.worktrees/fix-remove-skill-cleanup/dist/index.js update

Verified:

  • skill remove llm-wiki prints Removed plugin
  • .allagents/workspace.yaml ends with plugins: []
  • update reports Updating 0 plugin(s)
  • no skill remains under the synced skill directories

Multi-skill local plugin

cd /tmp/allagents-remove-skill-red-9vBqlQ/multi
node /home/entity/projects/EntityProcess/allagents.worktrees/fix-remove-skill-cleanup/dist/index.js skill remove skill-a
node /home/entity/projects/EntityProcess/allagents.worktrees/fix-remove-skill-cleanup/dist/index.js update

Verified:

  • skill remove skill-a removes only skill-a
  • .allagents/workspace.yaml keeps the plugin with skills: [skill-b]
  • update still syncs exactly one skill from that plugin

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying allagents with  Cloudflare Pages  Cloudflare Pages

Latest commit: dae13b9
Status: ✅  Deploy successful!
Preview URL: https://4afbadc7.allagents.pages.dev
Branch Preview URL: https://fix-remove-skill-cleanup.allagents.pages.dev

View logs

@christso christso merged commit f83f5e6 into main May 20, 2026
1 check passed
@christso christso deleted the fix/remove-skill-cleanup branch May 20, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant