Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces extensive performance instrumentation across critical data read and write paths in PyIceberg, focusing on timing and logging for scan, append, overwrite, and upsert operations. The changes add detailed log messages to help diagnose bottlenecks and optimize performance, and refactor some logic in the upsert operation to improve efficiency for insert filtering. Below are the most important changes grouped by theme.
Performance Instrumentation and Logging
pyiceberg/io/pyarrow.pyfor file scan tasks, delete file reads, and batch processing. This includes breakdowns for file opening, schema projection, filter preparation, batch reading, and delete file collection. [1]], [2]], [3]], [4]], [5]], [6]], [7]])pyiceberg/table/__init__.py, including append, overwrite, and upsert, to track the duration and row counts for each operation. [1]], [2]], [3]], [4]], [5]], [6]])Upsert Logic Improvements
File Planning Instrumentation
Infrastructure
pyiceberg/table/__init__.py. [1]], [2]])These changes provide much deeper visibility into the performance characteristics of PyIceberg's critical data paths, which will help with debugging and future optimization efforts.