Symm lowering #1659
Draft
Symm lowering #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
Details
| Benchmark suite | Current: 90f15e0 | Previous: f603104 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004296115000033751 s |
0.000004260189699562034 s |
1.01 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004192633999628015 s |
0.000004406429699884029 s |
0.95 |
scatter_sum / JaX / tpu / Primal |
0.0001415956161996 s |
0.0001248841227003 s |
1.13 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001420597381998 s |
0.0001351668211995 s |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
avik-pal
reviewed
Jan 5, 2026
Comment on lines
+26047
to
+26050
| struct FuseMulIntoSymm | ||
| : public CheckedOpRewritePattern<stablehlo::MulOp, FuseMulIntoSymm> { | ||
| using CheckedOpRewritePattern<stablehlo::MulOp, | ||
| FuseMulIntoSymm>::CheckedOpRewritePattern; |
Collaborator
There was a problem hiding this comment.
Make the original fusemul into a templated struct and specialize those
avik-pal
reviewed
Jan 5, 2026
Comment on lines
+26087
to
+26091
| struct FuseAddIntoSymm | ||
| : public CheckedOpRewritePattern<stablehlo::AddOp, | ||
| FuseAddIntoSymm>::CheckedOpRewritePattern { | ||
| using CheckedOpRewritePattern<stablehlo::AddOp, | ||
| FuseAddIntoSymm>::CheckedOpRewritePattern; |
avik-pal
reviewed
Jan 5, 2026
Comment on lines
+55
to
+56
| return rewriter.notifyMatchFailure(op, "Unknown backend: \"" + backend + | ||
| "\""); |
Collaborator
There was a problem hiding this comment.
write a fallback implementation
avik-pal
reviewed
Jan 5, 2026
| auto result = callOp.getResult(0); | ||
|
|
||
| rewriter.replaceAllUsesWith(op.getResult(), result); | ||
| // rewriter.eraseOp(op); // remove? |
Collaborator
There was a problem hiding this comment.
replaceAllUsesWith should remove the op automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.