-
Notifications
You must be signed in to change notification settings - Fork 25
Extend DotGeneral CSE to recognize operand-swapped equivalence #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
…emove unnecessary checks Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
| patterns.add<CSE<stablehlo::BroadcastInDimOp>, CSE<stablehlo::SliceOp>, | ||
| CSE<stablehlo::TransposeOp>, CSE<stablehlo::ConvertOp>, | ||
| CSE<stablehlo::PadOp>, CSE<stablehlo::DotGeneralOp>, | ||
| CSE<stablehlo::PadOp>, CSEDotGeneral, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can we reuse more of the CSE struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to follow the structure of the generic CSE pattern more closely. The implementation now directly mirrors the CSE template's iteration and checking logic, only adding the DotGeneral-specific swapped equivalence check. Commit: 9dea61e
…ture Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Plan: Expand DotGeneral CSE Pass to handle more equivalence
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.