-
Notifications
You must be signed in to change notification settings - Fork 25
Add stablehlo.einsum, stablehlo.unary_einsum diffrules
#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wsmoses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should copy the gradpad test which computes derivatives
|
@mofeing look here for example of how to deal with the einsum config.
I can help as well, but my question for you is offhand do you know the corresponding derivative rule for the config |
@wsmoses The reverse derivative for where Then the reverse derivatives are the following: I see that we need to do the following:
|
|
To start with let's not add complex stuff yet and do that in a subsequent PR. Other things will also need to be updated here as well so might as well do it generically for everything. |
|
[whoops meant to comment, not close...my b] |
|
In any case, want to try to add the config update? |
|
Yeah, I see that For example, where is |
|
Yeah. You have op which is the current operation so it’s essentially the
MLIR c++ api for your op
…On Tue, May 28, 2024 at 3:17 PM Sergio Sánchez Ramírez < ***@***.***> wrote:
Yeah, I see that GlobalExpr lets you write C++ code, right? I just don't
know what I have access to and the methods of op inside that code.
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXHYXP3QPXO3BYPOJYTZER7VLAVCNFSM6AAAAABIK6Q4HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGE4TKNJRGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
@wsmoses just uploaded the To do
|
|
@mofeing tests seem to fail, worth investigating? |
Fixes #82
@wsmoses I don't know much about LLVM, so I don't know how to implement them. But I wrote the prototypes and some annotations on how to continue the implementation.