This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Merged
Conversation
aarsilv
reviewed
May 2, 2024
| # Eppo Python SDK | ||
|
|
||
| ## Getting Started | ||
| [](https://github.com/Eppo-exp/python-sdk/actions/workflows/test-and-lint-sdk.yml) |
schmit
approved these changes
May 2, 2024
README.md
Outdated
Comment on lines
+46
to
+49
| variation = eppoClient.get_boolean_assignment('show-new-feature', user.id, { | ||
| 'country': user.country, | ||
| 'device': user.device, | ||
| }, False) |
There was a problem hiding this comment.
Nit: I think it's nicer if each argument gets a newline, otherwise the False is pretty hidden
README.md
Outdated
|
|
||
| Every Eppo flag has a return type that is set once on creation in the dashboard. Once a flag is created, assignments in code should be made using the corresponding typed function: | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
Suggested change
| ```javascript | |
| ```python |
README.md
Outdated
| Every Eppo flag has a return type that is set once on creation in the dashboard. Once a flag is created, assignments in code should be made using the corresponding typed function: | ||
|
|
||
| ```javascript | ||
| get_bool_assignment(...) |
There was a problem hiding this comment.
Suggested change
| get_bool_assignment(...) | |
| get_boolean_assignment(...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using our new JS README as a base, I updated this README. You can view the updated version here. Looking for typos, thing of that nature.
📈 📈 📈