This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Conversation
Author
|
Not too concerned with the mypy issues for these examples |
added 3 commits
May 29, 2024 22:14
schmit
force-pushed
the
sps/bandit-example
branch
from
53d6a5b to
0203cbf
Compare
petzel
reviewed
May 30, 2024
example/README.md
Outdated
| ``` | ||
|
|
||
| Set your API key in `main.py`: | ||
| Set your API key in `01_script.py`: |
Contributor
There was a problem hiding this comment.
The other two examples read from the EPPO_API_KEY env var. I'd recommend updating this to say to also set the env var, or make it consistent across the examples/use env var for all.
Author
There was a problem hiding this comment.
Yes see where you are coming from. I wanted to keep the script simple and just copy-pasting in the API key seems the best way for the very first script. The other examples show more of the best-practice. Agreed we should make it clearer how to set up though
petzel
approved these changes
May 30, 2024
Contributor
petzel
left a comment
petzel
left a comment
There was a problem hiding this comment.
one minor comment re: the README, overall LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Updates our examples, adds a FastAPI example and a bandit example
Description
Updated the examples/ folder to add additional examples.
How has this been tested?
Runs locally