This repository was archived by the owner on Nov 8, 2024. It is now read-only.
feat: [default polling to 10 seconds from 5 minutes; add configurable value] (FF-2686)#60
Merged
leoromanovsky merged 4 commits intomainfrom Jul 15, 2024
Merged
feat: [default polling to 10 seconds from 5 minutes; add configurable value] (FF-2686)#60leoromanovsky merged 4 commits intomainfrom
leoromanovsky merged 4 commits intomainfrom
Conversation
… value] (FF-2686)
leoromanovsky
force-pushed
the
lr/ff-2686
branch
from
b6a5bfb to
84e0055
Compare
aarsilv
approved these changes
Jul 11, 2024
Contributor
aarsilv
left a comment
aarsilv
left a comment
There was a problem hiding this comment.
Approving--despite the failing tests--as the change seem straightforward. Fine with 10 seconds, although most SDKs landed at the 30-second mark.
eppo_client/constants.py
Outdated
| POLL_JITTER_MILLIS = 30 * SECOND_MILLIS | ||
| POLL_INTERVAL_MILLIS = 5 * MINUTE_MILLIS | ||
| POLL_JITTER_SECONDS = 2 | ||
| POLL_INTERVAL_SECONDS = 10 |
Contributor
There was a problem hiding this comment.
Any reason not to do 30 like our other SDKs?
Member
Author
There was a problem hiding this comment.
golang is ten seconds - is 30 standard?
giorgiomartini0
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… value] (FF-2686)
labels: mergeable
Fixes: #issue
Motivation and Context
The poller is hard-coded to refresh every 5 minutes; this is too long between updates.
Description
How has this been tested?
There are some bandit data test failures not related to this change.