This repository was archived by the owner on Nov 8, 2024. It is now read-only.
fix: Use action key to select best scoring action#62
Merged
Conversation
schmit
reviewed
Aug 15, 2024
| best_action = max(action_scores, key=action_scores.get) | ||
| best_score = action_scores[best_action] | ||
| # Find the max score | ||
| best_score = max(action_scores.values()) |
There was a problem hiding this comment.
Damnit so close to keeping it a one line, but this takes the largest lexicographically ordered key
Suggested change
| best_score = max(action_scores.values()) | |
| max(d, key=lambda x: (d.get(x), x)) |
:(
|
Just mak esure to make the linter and formatter happy before merging :) |
aarsilv
approved these changes
Aug 16, 2024
Contributor
aarsilv
left a comment
aarsilv
left a comment
There was a problem hiding this comment.
👍
I'm ok with two lines 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes: FF-3060
👯 Universal Test PR: sdk-test-data/52
Motivation and Context
Tie-breaker by action name was introduced to the bandit evaluation algorithm to eliminate ambiguity when multiple actions are the top scoring
Description
How has this been tested?
Universal tests