This repository was archived by the owner on Nov 8, 2024. It is now read-only.
fix: | on dicts is only available with Python-3.9+#66
Merged
Conversation
leoromanovsky
approved these changes
Aug 22, 2024
Member
leoromanovsky
left a comment
leoromanovsky
left a comment
There was a problem hiding this comment.
confirmed that this produces equivalent output, thank you for finding it
Collaborator
Author
|
I thought that merging with Turns out, the order is defined (later values override previous ones) and is the same as for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
|on dicts is only available with Python-3.9+. Using Python-3.8 or lower, tests failDescription
Replace
|with unpacking.How has this been tested?
Run tests with Python 3.8.3