Closed
Conversation
csordasmarton
added
enhancement 🌟
test ☑️
csordasmarton
force-pushed
the
cppcheck
branch
4 times, most recently
from
2ab7e38 to
e188c63
Compare
csordasmarton
force-pushed
the
cppcheck
branch
2 times, most recently
from
360589d to
b28793e
Compare
csordasmarton
force-pushed
the
cppcheck
branch
from
b28793e to
049182d
Compare
gamesh411
reviewed
Aug 29, 2019
analyzer/codechecker_analyzer/analyzers/clangtidy/config_handler.py
Outdated
Show resolved
Hide resolved
analyzer/codechecker_analyzer/analyzers/clangtidy/config_handler.py
Outdated
Show resolved
Hide resolved
gyorb
suggested changes
Sep 2, 2019
| """ | ||
| raise NotImplementedError("Subclasses should implement this!") | ||
|
|
||
| @classmethod |
Contributor
There was a problem hiding this comment.
using the @abstractmethod decorator wouldn't be better?
| return clang | ||
|
|
||
| @classmethod | ||
| def version_compatible(cls, configured_binary, environ): |
Contributor
There was a problem hiding this comment.
Should this be a classmethod?
| return self.__available_checkers | ||
|
|
||
| def __gen_name_variations(self): | ||
| def get_analyzer_checkers(self, environ): |
Contributor
There was a problem hiding this comment.
using the @abstractmethod decorator wouldn't be better?
| @@ -1,7 +1,7 @@ | |||
| NORMAL#CodeChecker log --output $LOGFILE$ --build "make context_hash" --quiet | |||
| NORMAL#CodeChecker analyze $LOGFILE$ --output $OUTPUT$ --report-hash=context-free | |||
| NORMAL#CodeChecker analyze $LOGFILE$ --output $OUTPUT$ --report-hash=context-free --analyzers clang-tidy clangsa | |||
Contributor
There was a problem hiding this comment.
Why do we need to disable cppcheck only for the context free hash tests?
| @@ -0,0 +1 @@ | |||
| -UHAVE_NULL_DEREFERENCE No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Can we add comments to this file? A comment would be nice about the fact that this is how you can disable an error in cppcheck.
analyzer/tests/functional/analyze_and_parse/test_files/cppcheck_warning.output
Show resolved
Hide resolved
Move `analyzer_plugins` function and `analyzer_plugins_dir` variable under the `ClangSAConfigHandler` class because these are only used by this analyzer.
csordasmarton
force-pushed
the
cppcheck
branch
from
ca9b826 to
f2c9ffb
Compare
Contributor
|
The support for cppcheck will be done differently after some discussion. |
vodorok
added a commit
to vodorok/codechecker
that referenced
this pull request
Jun 9, 2022
This commit adds support for the Cppcheck analyzer. The following two commits are also squashed into this: * [test] Add new test cases for Cppcheck support * [analyzer] Check version compatibility This commit is the resurrection of works made by Márton Csordás. The original pull request Ericsson#2290 had three more refactoring related change sets which were omitted in this. Some changes were added in compared to the original commits: * The Cppcheck report converter is used to get the results in the result_handler. * Some small small compatibility changes were added because of the changes in the code base. Co-authored-by: bruntib <bruntib@users.noreply.github.com> Co-authored-by: vodorok <vodorok@gmail.com>
vodorok
added a commit
to vodorok/codechecker
that referenced
this pull request
Jun 9, 2022
This commit adds support for the Cppcheck analyzer. The following two commits are also squashed into this: * [test] Add new test cases for Cppcheck support * [analyzer] Check version compatibility This commit is the resurrection of works made by Márton Csordás. The original pull request Ericsson#2290 had three more refactoring related change sets which were omitted in this. Some changes were added in compared to the original commits: * The Cppcheck report converter is used to get the results in the result_handler. * The hash calculation logic has been uplifted to the latest one. * Some small small compatibility changes were added because of the changes in the code base. Co-authored-by: bruntib <bruntib@users.noreply.github.com> Co-authored-by: vodorok <vodorok@gmail.com>
vodorok
added a commit
to vodorok/codechecker
that referenced
this pull request
Aug 10, 2022
This commit adds support for the Cppcheck analyzer. The following two commits are also squashed into this: * [test] Add new test cases for Cppcheck support * [analyzer] Check version compatibility This commit is the resurrection of works made by Márton Csordás. The original pull request Ericsson#2290 had three more refactoring related change sets which were omitted in this. Some changes were added in compared to the original commits: * The Cppcheck report converter is used to get the results in the result_handler. * The hash calculation logic has been uplifted to the latest one. * Some small small compatibility changes were added because of the changes in the code base. Co-authored-by: bruntib <bruntib@users.noreply.github.com> Co-authored-by: vodorok <vodorok@gmail.com>
whisperity
pushed a commit
that referenced
this pull request
Aug 19, 2022
[analyzer] Cppcheck support This commit adds support for the Cppcheck analyzer. The following two commits are also squashed into this: * [test] Add new test cases for Cppcheck support * [analyzer] Check version compatibility This commit is the resurrection of works made by Márton Csordás. The original pull request #2290 had three more refactoring-related change sets which were omitted in this. Some changes were added in compared to the original commits: * The Cppcheck report converter is used to get the results in the result_handler. * The hash calculation logic has been uplifted to the latest one. * Some small small compatibility changes were added because of the changes in the code base. Further changes: * Cppcheck now works in a raw directory instead of directly into the workspace folder. * Exponential explosion of reports in plist files are now fixed. * Checker disable now works on native levels. * The `--disable <cppcheck_check>` now properly translates to `--suppress <cppcheck_check>` in the cppcheck invocation. * The current run configuration of cppcheck is `--enable=all`. Added two new input paramaters: * With `cppcheck-addons` extra cppcheck checkers can be specified. * With `cppcheck-libraries` the cppcheck library definitions can be added. Cppcheck reports have to be "fixed" for Codechecker to be able to properly interpret them. The actual error message must be added to any multistep report as a last bug path event. Cppcheck checkers are prefixed with the `cppcheck-` prefix. Co-authored-by: Márton Csordás <csordasmarton92@gmail.com> Co-authored-by: bruntib <bruntib@gmail.com> Co-authored-by: vodorok <vodorok@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.