[diff] Fix a CLI remote-remote bug where we checked the detection status #3996
Merged
bruntib merged 1 commit intoEricsson:masterfrom Sep 21, 2023
Merged
Conversation
Szelethus
force-pushed
the
tag_diff_detection_status_bugfix
branch
from
e62cc70 to
d3d1d2f
Compare
Szelethus
added
CLI 💻
Szelethus
force-pushed
the
tag_diff_detection_status_bugfix
branch
from
d3d1d2f to
5f482f8
Compare
Ideally, when we use CodeChecker cmd diff, we should return exactly what the server API calls return. We obviously can't do that when either the baseline or the newline result contains a local directory, since they are not on the server. In that case, we need to parse the results, check for review status rules on the server, etc. However, when both operands _are_ on the server, there is no need to do additional filtering, lets just trust that the server returns correct results. If not, we should fix it the server.
Szelethus
force-pushed
the
tag_diff_detection_status_bugfix
branch
from
5f482f8 to
0b20fc3
Compare
bruntib
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, when we use CodeChecker cmd diff, we should return exactly what
the server API calls return. We obviously can't do that when either the
baseline or the newline result contains a local directory, since they
are not on the server. In that case, we need to parse the results, check
for review status rules on the server, etc.
However, when both operands are on the server, there is no need to do
additional filtering, lets just trust that the server returns correct
results. If not, we should fix it the server.
Depends on #3995.