optimize batch insert query for reward accounts #3836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
changed the title
imabdulbasit
changed the title
imabdulbasit
force-pushed
the
ab/reward-accounts-batch-insert
branch
from
6f145b0 to
fa38f1c
Compare
imabdulbasit
requested review from
bfish713,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
imabdulbasit
force-pushed
the
ab/reward-accounts-batch-insert
branch
from
8e28faf to
85fd42c
Compare
bfish713
approved these changes
Dec 22, 2025
lukaszrzasik
approved these changes
Dec 22, 2025
Contributor
lukaszrzasik
left a comment
lukaszrzasik
left a comment
There was a problem hiding this comment.
LGTM although you might want somebody more familiar with the query service code to have a look as well.
jbearer
added a commit
that referenced
this pull request
Jan 5, 2026
* Delay storage in `add_epoch_root` (#3840) * optimize batch insert query for reward accounts (#3836) * WIP: batch inserts * add tests * support batch inserts for sqlite * use batch insert for state update * clippy * cleanup * lint * use hashmap * move test to slow-tests * fix test attempt1 * test w 20k accounts --------- Co-authored-by: sveitser <sveitser@gmail.com> * Cargo audit fixes --------- Co-authored-by: ss-es <155648797+ss-es@users.noreply.github.com> Co-authored-by: Abdul Basit <45506001+imabdulbasit@users.noreply.github.com> Co-authored-by: sveitser <sveitser@gmail.com> Co-authored-by: jbearer <11866082+jbearer@users.noreply.github.com>
jbearer
added a commit
that referenced
this pull request
Jan 5, 2026
* Implement light client header fetching * Fix test merkle trees * Add assertions for specific errors * Clean up light client API error handling * [Bot] Audit fixes (#3859) * Delay storage in `add_epoch_root` (#3840) * optimize batch insert query for reward accounts (#3836) * WIP: batch inserts * add tests * support batch inserts for sqlite * use batch insert for state update * clippy * cleanup * lint * use hashmap * move test to slow-tests * fix test attempt1 * test w 20k accounts --------- Co-authored-by: sveitser <sveitser@gmail.com> * Cargo audit fixes --------- Co-authored-by: ss-es <155648797+ss-es@users.noreply.github.com> Co-authored-by: Abdul Basit <45506001+imabdulbasit@users.noreply.github.com> Co-authored-by: sveitser <sveitser@gmail.com> Co-authored-by: jbearer <11866082+jbearer@users.noreply.github.com> * Fix error handling tests --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ss-es <155648797+ss-es@users.noreply.github.com> Co-authored-by: Abdul Basit <45506001+imabdulbasit@users.noreply.github.com> Co-authored-by: sveitser <sveitser@gmail.com> Co-authored-by: jbearer <11866082+jbearer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked batch insert from #3834