Fee contract upgrade #3850
Open
Fee contract upgrade #3850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysiahuggins
commented
Dec 18, 2025
|
|
||
| // Verify current version before upgrading | ||
| let curr_version = proxy.getVersion().call().await?; | ||
| if curr_version.majorVersion != 1 { |
Contributor
Author
There was a problem hiding this comment.
kept this simple to allow for patch upgrades within v1
|
|
||
| // Remove old implementation from cache so we deploy a new one | ||
| contracts.0.remove(&Contract::FeeContract); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
we can allow an explicit flag e.g. --patch-upgrade to allow for redeployment of the same contract and upgrade, in order to do a patch upgrade
alysiahuggins
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review:
getVersion)upgrade_fee_v1and multisig upgrade helpers