-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for translating command description and usage #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think the description and usage messages should be included in |
|
I thought about that, but I also thought it would be valuable to not have the English version duplicated potentially 3 times (one in On second thought though, how about we just remove all of the messages from plugin.yml? Then, we have them consolidated solely in the message files. If I can get a thumbs up for this idea I'll go ahead and do that (this will probably be a bit of somewhat manual work). |
|
plugin.yml should always be as descriptive as possible. If message duplication is a concern, add the messages to plugin.yml and messages.properties during building, pulling from messages_en.properties! :) |
|
Pulling from
The only concern is with having to manually sync description/usage strings between |
I don't see any syntax in messages_en? |
|
@mbax edit:
|
As the title implies, this PR allows translators and server owners to change the command description and usage messages. This avoids the need for people to maintain their own versions of Essentials with custom plugin.yml files. The implementation here uses empty values to indicate that default description or usage from plugin.yml should be used.
Example usage
config.yml
messages_de.properties
commands.yml
Closes #3376