Add support for local and global chats in Discord #4684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
3165a7e to
1741621
Compare
triagonal
added
module: discord
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
1741621 to
afb5859
Compare
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
afb5859 to
77c5f81
Compare
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
77c5f81 to
448fcfe
Compare
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
448fcfe to
1db6cc9
Compare
brawaru
force-pushed
the
feat/discord-esschat-events
branch
2 times, most recently
from
9fd7a6c to
d265ce3
Compare
JRoy
requested changes
Aug 19, 2022
EssentialsDiscord/src/main/java/net/essentialsx/discord/JDADiscordService.java
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/discord/DiscordSettings.java
Show resolved
Hide resolved
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
d265ce3 to
f6c49dd
Compare
Member
|
@brawaru could you update this to the latest 2.x so we can get this merged :) |
This change makes use of added separate events for local and global chats, making it possible to change formatting of messages sent from different chat types, as well as disable them altogether (for example, if you don't want to see local chat messages in Discord). By default Essentials Discord will continue to use Bukkit chat events without any kind of separation, you must explicitly opt in to have new behaviour by changing use-essential-events to true.
brawaru
force-pushed
the
feat/discord-esschat-events
branch
from
f6c49dd to
26d8033
Compare
Contributor
Author
|
Rebased, but haven't tested anything yet. Will try to when I have time. |
JRoy
requested changes
May 1, 2023
Member
JRoy
left a comment
JRoy
left a comment
There was a problem hiding this comment.
i don't know why i requested these be enabled by default, they should be disabled 😄
EssentialsDiscord/src/main/java/net/essentialsx/discord/DiscordSettings.java
Outdated
Show resolved
Hide resolved
JRoy
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a draft since it requires #4683 to be merged first.
Information
×
Details
Proposed feature:
This change makes use of added separate events for local and global chats in , making it possible to change the formatting of messages sent from different chat types, as well as disable them altogether (for example, if you don't want to see local chat messages in Discord).
By default Essentials Discord will continue to use Bukkit chat events without any kind of separation, you must explicitly opt in to have new behaviour by changing use-essential-events to true.
Environments tested:
OS: Windows 10 20H2.
Java version:
Demonstration:
Fixed #4989