Added option to limit amount of lore lines #4773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
requested changes
Jan 23, 2022
Member
JRoy
left a comment
JRoy
left a comment
There was a problem hiding this comment.
Few things plus please add a essentials.itemlore.bypass permission to bypass this limit
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Contributor
Author
|
Thanks! Looks good to me. I'll add the bypass shortly. |
JRoy
added
status: waiting on author
Member
|
Hey @justinmtech, any updates on these changes? |
JRoy
approved these changes
Aug 8, 2023
JRoy
changed the title
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #4772
Details
Proposed feature:
Configure the max lines of lore that can be added with /itemlore add.
Adds config setting "max-item-lore" and an error message when a user tries to add a new line of lore to an item with the max.
#4772
Environments tested:
OS: Windows 10
Java version: OpenJDK 17.0.1
Demonstration:
Screenshot: https://imgur.com/a/dQ6TedQ
Plugin Download: https://www.dropbox.com/s/jpl35j9rr57bs8m/EssentialsX-2.19.3-dev%2B10-b220c22-max-lore-feature-4772.jar?dl=0