Skip to content

Migrate Discord module to JDA 5 #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JRoy merged 6 commits into from
Jul 1, 2023
Merged

Migrate Discord module to JDA 5 #4786

JRoy merged 6 commits into from
Jul 1, 2023

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Jan 29, 2022 •
edited
Loading

Updates EssentialsXDiscord to use the v5 release of JDA

No change in API and link module will require zero updates, as both don't touch JDA at all.

merge EssentialsX/Website#92 with this

REBASE AND MERGE

@JRoy JRoy added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels Jan 29, 2022
@JRoy JRoy added this to the 2.20.0 milestone Jan 29, 2022
pop4959
pop4959 reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@JRoy JRoy force-pushed the dependencies/jda-5 branch from 687f56c to 85b906f Compare February 20, 2022 22:21
@JRoy JRoy marked this pull request as ready for review July 5, 2022 17:40
@JRoy JRoy marked this pull request as draft July 5, 2022 17:41
@JRoy
Copy link
Member Author

JRoy commented Aug 17, 2022

TODO: use jda's SplitUtil in next JDA bump

@JRoy
Copy link
Member Author

JRoy commented Aug 21, 2022

TODO: use jda's SplitUtil in next JDA bump

nvm my code is better

@JRoy JRoy mentioned this pull request Aug 22, 2022
Closed
@JRoy JRoy modified the milestones: 2.20.0, 2.21.0 Apr 28, 2023
@JRoy JRoy modified the milestones: 2.21.0, 2.20.1 Jun 20, 2023
@JRoy JRoy marked this pull request as ready for review June 20, 2023 14:56
@JRoy JRoy force-pushed the dependencies/jda-5 branch 2 times, most recently from 53736b4 to d554eab Compare June 20, 2023 18:02
@JRoy JRoy mentioned this pull request Jun 26, 2023
Closed
@JRoy JRoy force-pushed the dependencies/jda-5 branch from ae180dc to 5487688 Compare July 1, 2023 19:44
@JRoy JRoy force-pushed the dependencies/jda-5 branch from 5487688 to fe613b9 Compare July 1, 2023 21:41
@JRoy JRoy merged commit d57094c into 2.x Jul 1, 2023
@JRoy JRoy deleted the dependencies/jda-5 branch July 1, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pop4959 pop4959 pop4959 left review comments

@mdcfe mdcfe mdcfe approved these changes

+1 more reviewer

@Andre601 Andre601 Andre601 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: discord Issues or PRs for the EssentialsDiscord module type: enhancement Features and feature requests.

Projects

None yet

Milestone

2.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@JRoy @mdcfe @Andre601 @pop4959