Skip to content

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Jun 7, 2022

for the new chat stuff, I'll tackle that once we do adventure support (#4717) in 2.20 or I may use something md_5 hacks into his api if its easy enough

thanks for your concern @broccolai

@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Jun 7, 2022
@JRoy JRoy added this to the 2.19.5 milestone Jun 7, 2022
@JRoy
Copy link
Member Author

JRoy commented Jun 7, 2022

WHOEVER MERGES THIS PLEASE USE REBASE AND MERGE

Copy link

@sando1234 sando1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found nothing wrong :D.

@mdcfe mdcfe force-pushed the mc/1.19 branch 2 times, most recently from 34b8610 to 95119b1 Compare June 15, 2022 14:29
JRoy and others added 7 commits June 15, 2022 16:05
Note: this action was performed by a human (@mdcfe) under the
Flask-Bot account.
`commons-lang3` is scheduled for removal by Spigot.

This commit reimplements the methods we use from StringUtils in StringUtil, and replaces NumberUtils.isDigits(String) with NumberUtil.isLong(String).
@mdcfe mdcfe merged commit a7f602e into 2.x Jun 15, 2022
@JRoy JRoy deleted the mc/1.19 branch June 15, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants